Skip to content

Refactor foreign keys and relationships to pure logic #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Refactor foreign keys and relationships to pure logic #901

wants to merge 35 commits into from
+1,048 −767

Conversation

@wu-clan
Copy link
Member

@wu-clan wu-clan commented Nov 6, 2025

Close #825

@wu-clan
Copy link
Member Author

wu-clan commented Nov 6, 2025 •
edited
Loading

TODO:

全局：

  • 删除所有模型关系和外键

应用：

  • 重构用户部分
  • 重构部门部分
  • 重构角色部分
  • 重构菜单部分
  • 重构用户信息缓存清理

插件：

  • 重构代码生成部分
  • 重构字典部分
  • 重构社交用户部分

wu-clan added 19 commits November 7, 2025 15:55
@wu-clan
Update the user paginate
7af81d1
@wu-clan
Update user create and update
7cf1aea
@wu-clan
Update dept select and delete
b19b237
@wu-clan
Rename the join query functions
5ccdc1e
@wu-clan
Update select_join_serialize doc and README
bd0c0bc
@wu-clan
Fix typo in README
fbaf29f
@wu-clan
Update the user delete
44aca81
@wu-clan
Update the user social
578b9cd
@wu-clan
Merge branch 'master' into logical-foreign-keys
5243193 
# Conflicts:
#	backend/app/admin/crud/crud_dept.py
#	backend/app/admin/crud/crud_user.py
@wu-clan
Update the dict plugin crud
a4714c5
@wu-clan
Update the dict plugin version
9fef37c
@wu-clan
Bump dependencies and pre-commits
68f007f
@wu-clan
Update the code generator plugin crud
759db21
@wu-clan
Update the menu crud
bea3691
@wu-clan
Update the role crud
3a69382
@wu-clan
Update the data scope and rule crud
ce9a4d4
@wu-clan
Restore get_paginated to get_select
36f137c
@wu-clan
Update the code generator plugin version
98baaec
@wu-clan
Add the py version in pre-commit
da8d698
@downdawn downdawn self-requested a review November 10, 2025 03:48
@downdawn
Copy link
Collaborator

downdawn commented Nov 10, 2025

image image

model这样设计，crud可正常使用selectinload

可以验证一下这个可行性，可能会更加优雅

@wu-clan
Copy link
Member Author

wu-clan commented Nov 10, 2025

此 PR 是为了删除任何表之间的物理外键约束（fk、cascade)

定义 primaryjoin 确实不会创建物理外键约束, 仅为 join on 条件，但是，通常不建议这么做，任何 sql 条件都应尽可能地在代码中实现，这有助于规避潜在问题

事实上，仅使用 relationship 而不使用 fk 也可以正常工作，只是需要手动处理级联操作（cascade）

综上所述，仅使用 relationship 似乎也能达到此 PR 目标，但是，对于明确规定禁止使用 relationship 的要求，这仍然无法满足

我的最终目标是，在此 PR 被合并之前，完成 PR 中列出的所有任务，然后将主分支进行最后发版并创建备份分支

@wu-clan
Copy link
Member Author

wu-clan commented Nov 10, 2025 •
edited
Loading

就像我在其他地方回复的一样，相比于以下实现，我已为尽可能保持代码兼容性做了一些努力

点击这里展开 941d69d7cedd3dd65dd906183dc590e2

@wu-clan wu-clan marked this pull request as ready for review November 11, 2025 08:27
@wu-clan
Delete cache cleanup comments
c79e73b
@wu-clan
Merge branch 'master' into logical-foreign-keys
679a231 
# Conflicts:
#	backend/app/admin/service/data_rule_service.py
#	backend/app/admin/service/dept_service.py
#	backend/common/security/permission.py
#	backend/plugin/oauth2/api/v1/user_social.py
#	backend/plugin/oauth2/crud/crud_user_social.py
#	backend/plugin/oauth2/service/user_social.py
@wu-clan
Merge branch 'master' into logical-foreign-keys
833ed2c 
# Conflicts:
#	backend/app/admin/service/data_scope_service.py
@wu-clan
Update the oauth2 plugin version
35c555c
@wu-clan
Copy link
Member Author

wu-clan commented Nov 11, 2025 •
edited
Loading

Hi~ @downdawn

当前 PR 任务已完成，可以帮忙 review 吗？

如果有任何问题，请随时 ping 我，以确保此 PR 在被合并之前，我可以为当前主分支制作最后发版和备份

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@downdawn downdawn downdawn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

逻辑外键

3 participants

@wu-clan @downdawn